[webkit-reviews] review granted: [Bug 34435] [Gtk] libsoup critical warning in media player http cookies injection code : [Attachment 48002] refactored HTTP headers injection code

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 34435: [Gtk] libsoup critical warning in media player http cookies
injection code
https://bugs.webkit.org/show_bug.cgi?id=34435

Attachment 48002: refactored HTTP headers injection code
https://bugs.webkit.org/attachment.cgi?id=48002&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 151	 // Do injection only for http(s) uris.
 152	 if (g_ascii_strncasecmp(uri->scheme, "http", 4)
 153	     || g_ascii_strncasecmp(uri->scheme, "https", 5))
 154	     return;

I think it's better to use SOUP_URI_VALID_FOR_HTTP() here instead.