[webkit-reviews] review requested: [Bug 34527] Improve/maintain Haiku port : [Attachment 48036] Various fixes to mouse/wheel/keyboard event propagation on Haiku
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 3 08:19:57 PST 2010
Stephan Aßmus <superstippi at gmx.de> has asked for review:
Bug 34527: Improve/maintain Haiku port
https://bugs.webkit.org/show_bug.cgi?id=34527
Attachment 48036: Various fixes to mouse/wheel/keyboard event propagation on
Haiku
https://bugs.webkit.org/attachment.cgi?id=48036&action=review
------- Additional Comments from Stephan Aßmus <superstippi at gmx.de>
This patch can be applied individually.
* Some compiler warnings were fixed.
* Wrong coordinates were extracted from the Haiku event BMessage, resulting in
an offset for mouse moved events.
* Improved the compatibility of keyboard events.
* Use the correct code for the tab/backspace key in EventHandlerHaiku.cpp and
fix the build by not including PlatformScrollBar.h
* Generate a correct timestamp for mouse/wheel events. The value is documented
as being in seconds.
* Fill the modifier flags in mouse/wheel events.
More information about the webkit-reviews
mailing list