[webkit-reviews] review granted: [Bug 33616] Inspector interface allows insecure data transfer : [Attachment 48019] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 33616: Inspector interface allows insecure data transfer
https://bugs.webkit.org/show_bug.cgi?id=33616

Attachment 48019: patch
https://bugs.webkit.org/attachment.cgi?id=48019&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    ScriptFunctionCall function(scriptState, m_injectedScriptObject,
"getCallFrames");

"getCallFrames" -> "callFrames" ?

> +    ScriptValue callFramesValue = function.call();
> +    return callFramesValue.toString(scriptState);
> +}
> +
> +String InjectedScript::wrapAndStringify(ScriptValue value)
> +{
> +    ASSERT(!hasNoValue());
> +    ScriptState* scriptState = m_injectedScriptObject.scriptState();
> +    ScriptFunctionCall wrapFunction(scriptState, m_injectedScriptObject,
"wrapAndStringifyObject");
> +    wrapFunction.appendArgument(value);
> +    wrapFunction.appendArgument("console");

Should this be reflected in the method name? wrapAndStringifyForConsole?