[webkit-reviews] review requested: [Bug 28293] [Chromium] event.datatransfer.getdata("text/uri-list") treated the same as getdata("URL") : [Attachment 48010] patch - correct handling of "URL" vs. "text/uri-list" for Chromium, incl. new layout test

[bugzilla-daemon at webkit.org]

Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 28293: [Chromium] event.datatransfer.getdata("text/uri-list") treated the
same as getdata("URL")
https://bugs.webkit.org/show_bug.cgi?id=28293

Attachment 48010: patch - correct handling of "URL" vs. "text/uri-list" for
Chromium, incl. new layout test
https://bugs.webkit.org/attachment.cgi?id=48010&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
New-and-improved version of the patch, including an all-new layout test.

This now also should handle comments in the URI list correctly.

The patch also tries to correctly handle clearData() in that file data is not
deleted on a call to clearData() without arguments, as specified in the HTML5
spec.

Also added is a new layout test to verify the handling of getData & setData for
"URL" vs. "text/uri-list". The test is skipped on all other platforms, since
this functionality is not fully implemented there either. (The previous layout
test is contained in the patch for the new issue 34512).

Nevertheless, I would also consider this Chromium patch just an interim patch,
since it still doesn't support the HTML5 spec fully. Esp. it doesn't yet handle
arbitrary MIME types in getData and setData.