[webkit-reviews] review denied: [Bug 34489] [Qt] Text codec lookup is slow : [Attachment 47978] Updated patch.

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has denied David Leong
<david.leong at nokia.com>'s request for review:
Bug 34489: [Qt] Text codec lookup is slow
https://bugs.webkit.org/show_bug.cgi?id=34489

Attachment 47978: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=47978&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>

> +	   QtTextCodec creation is very slow
> +	   https://bugs.webkit.org/show_bug.cgi?id=34489

Better to describe the solution rather than only the problem.
Maybe something like "[Qt] Text codec caching to speed up codec look-up".

> +typedef QHash<QString, QTextCodec*> TextCodecHash;
> +static TextCodecHash textCodecCache;

I guess static problem with RVCT 2.2 has been solved in the past. Maybe Laszlo
knows this?

> +    // qDebug() << "TextCodecQt::TextCodecQt() - " << name;

Do we want this?

BTW, try to ask Simon about his opinion, he's the text expert :)