[webkit-reviews] review requested: [Bug 34489] [Qt] Text codec lookup is slow : [Attachment 47978] Updated patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 15:18:50 PST 2010


David Leong <david.leong at nokia.com> has asked  for review:
Bug 34489: [Qt] Text codec lookup is slow
https://bugs.webkit.org/show_bug.cgi?id=34489

Attachment 47978: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=47978&action=review

------- Additional Comments from David Leong <david.leong at nokia.com>
Updated the patch as per Laszlo and Ariya's suggestion. 

-Added change log
-Ran style check script
-Updated use of value() instead of iterator as per Ariya

I could not move the static to the class, it generated a missing symbol with
RVCT 2.2.


More information about the webkit-reviews mailing list