[webkit-reviews] review denied: [Bug 34495] ENABLE_DATABASE and ENABLE_DOM_STORAGE don't work in IDL files. : [Attachment 47970] Fix for bug 34495.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 14:06:01 PST 2010


David Levin <levin at chromium.org> has denied Lyon Chen
<lyon.chen at torchmobile.com>'s request for review:
Bug 34495: ENABLE_DATABASE and ENABLE_DOM_STORAGE don't work in IDL files.
https://bugs.webkit.org/show_bug.cgi?id=34495

Attachment 47970: Fix for bug 34495.
https://bugs.webkit.org/attachment.cgi?id=47970&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- because it looks like this breaks the build for both qt and gtk.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +2010-02-02  Lyon Chen  <liachen at rim.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   ENABLE_DATABASE and ENABLE_DOM_STORAGE don't work in IDL files.
> +	   https://bugs.webkit.org/show_bug.cgi?id=34495
> +
> +	   No new tests. (OOPS!)

This should either list what tests cover this functionality or explain that
there is no new functionality so no new tests. (I think you want the second in
this case.)
\


More information about the webkit-reviews mailing list