[webkit-reviews] review requested: [Bug 29177] [GTK] Right click does not activate text entry : [Attachment 47962] Proposed patch

[bugzilla-daemon at webkit.org]

José Millán Soto <jmillan at igalia.com> has asked  for review:
Bug 29177: [GTK] Right click does not activate text entry
https://bugs.webkit.org/show_bug.cgi?id=29177

Attachment 47962: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47962&action=review

------- Additional Comments from José Millán Soto <jmillan at igalia.com>
This patch works in the pages commented in comment 2.

There were already layout tests for this, but they were skipped in GTK. This
patch removes them from the Skipped list.
Also, popup menu position when invoked via keyboard is improved (popup menu
appeared where the mouse cursor was, which could led to confusion if it was not
above the selected node).

Click event handling using javascript is tested in
fast/events/mouse-click-events.html; WebKitGTK fails that text, but in the
results page it can be seen that the right button is correctly handled.