[webkit-reviews] review denied: [Bug 34474] Share the DRT values maxViewWidth/Height among ports : [Attachment 47925] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 34474: Share the DRT values maxViewWidth/Height among ports
https://bugs.webkit.org/show_bug.cgi?id=34474

Attachment 47925: Patch v1
https://bugs.webkit.org/attachment.cgi?id=47925&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Good goal. But why not share these in a header as plain old C++ constants? It
seems wrong to put these into config.h as macros. Macros are deprecated and
should only be used when there is no better solution. And config.h should be
kept as simple as possible. We're working longer term to simplify further.

I suggest we just move maxViewWidth and maxViewHeight from DumpRenderTree.mm
into LayoutTestController.h and use those in LayoutTestController.cpp.