[webkit-reviews] review granted: [Bug 34469] Web Inspector: Separate OS type from OS version (WebInspector.platform) : [Attachment 47931] [PATCH] Suggested solution
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 2 08:27:55 PST 2010
Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 34469: Web Inspector: Separate OS type from OS version
(WebInspector.platform)
https://bugs.webkit.org/show_bug.cgi?id=34469
Attachment 47931: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=47931&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +body.detached.platform-snowleopard #toolbar {
I'd suggest to rename "platform-snowleopard" to "platform-mac-snowleopard" or
"mac-snowleopard"
> + return WebInspector.PlatformFlavor.WindowsVistaOrLater;
We don't seem to be consistent. We have vista or later, but don't have snow
leopard or later. Should Vista imply newer platforms?
More information about the webkit-reviews
mailing list