[webkit-reviews] review denied: [Bug 34435] [Gtk] libsoup critical warning in media player http cookies injection code : [Attachment 47916] refactored HTTP headers injection code

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 34435: [Gtk] libsoup critical warning in media player http cookies
injection code
https://bugs.webkit.org/show_bug.cgi?id=34435

Attachment 47916: refactored HTTP headers injection code
https://bugs.webkit.org/attachment.cgi?id=47916&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 8	   * GNUmakefile.am: Added libsoup and gstreamer CFLAGS/LDFLAGS to
JavascriptCore build.

This is a bad thing we want to avoid. JSC should not need to depend on those.
For GRefPtr mrobinson added files to WebCore/platform/gtk. I think this is the
way to go for these GOwnPtr types.

 11	    not be done neither the User-Agent not Referer were injected.

s/not/nor/

 142	 char* location;
 143	 g_object_get(element.get(), "location", &location, NULL);
 144 
 145	 GOwnPtr<SoupURI> uri(soup_uri_new(location));
 146	 g_free(location);

You could use GOwnPtr for char* location, and the other char*'s in this code,
by the way!

r- for the addition of unneeded deps on JSC.