[webkit-reviews] review denied: [Bug 34329] Cannot inspect Web Inspector in QtLauncher : [Attachment 47903] Patch to enable inspecting the web inspector in the QtLauncher
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 2 01:01:12 PST 2010
Holger Freyther <zecke at selfish.org> has denied Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 34329: Cannot inspect Web Inspector in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=34329
Attachment 47903: Patch to enable inspecting the web inspector in the
QtLauncher
https://bugs.webkit.org/attachment.cgi?id=47903&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
I love the patch. It sucks to have comments on a one liner. So if you fix them
you can land the patch rightaway.
> + Need a short description and bug URL (OOPS!)
Please remove this. You have done everything that is needed for this.
> InspectorClientWebPage(QObject* parent = 0)
> - : QWebPage(parent)
> + : QWebPage(parent)
Even if you fix the style, we normally tend to do this in two separate commits.
You have my rubber stamp to fix this style issue with the code.
More information about the webkit-reviews
mailing list