[webkit-reviews] review denied: [Bug 34317] [GStreamer] Add a WebKit HTTP/HTTPS source that uses WebKit's network infrastructure : [Attachment 47766] 0001-Add-webkitwebsrc-a-GStreamer-HTTP-HTTPS-source-using.patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Sebastian Dröge
<slomo at circular-chaos.org>'s request for review:
Bug 34317: [GStreamer] Add a WebKit HTTP/HTTPS source that uses WebKit's
network infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317

Attachment 47766:
0001-Add-webkitwebsrc-a-GStreamer-HTTP-HTTPS-source-using.patch
https://bugs.webkit.org/attachment.cgi?id=47766&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +	-gstapp-0.10

Are you sure, you don't want -lgstapp-0.10 here?



> +    priv->appsrc = GST_APP_SRC(gst_element_factory_make("appsrc", 0));
> +    if (!priv->appsrc) {
> +	   GST_ERROR_OBJECT(src, "Failed to create giostreamsrc");
> +	   return;
> +    }

> +static void webkit_web_src_stop(WebkitWebSrc* src, gboolean
resetRequestedOffset)
> +{

> +    gst_app_src_set_caps(priv->appsrc, 0);

Does this mix well? Will it crash or just print a critical warning? Or will
this never happen because the src_change_state will report a missing plugin and
then stop is never called?

The next question is can the stop method be called multiple times? Or is there
any gurantee that GStreamer will not do this?