[webkit-reviews] review granted: [Bug 34460] [Chromium] Add WebSecurityOrigin::createFromString factory : [Attachment 47908] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 2 00:09:18 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 34460: [Chromium] Add WebSecurityOrigin::createFromString factory
https://bugs.webkit.org/show_bug.cgi?id=34460

Attachment 47908: Patch
https://bugs.webkit.org/attachment.cgi?id=47908&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebSecurityOrigin.h
> +    WEBKIT_API static WebSecurityOrigin createFromString(const WebString&
origin);

nit: nix the origin parameter name.

otherwise, r=me


More information about the webkit-reviews mailing list