[webkit-reviews] review requested: [Bug 34463] [Gtk] webkitgtk crashed when Orca open : [Attachment 47909] Additional sanity checking

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 34463: [Gtk] webkitgtk crashed when Orca open
https://bugs.webkit.org/show_bug.cgi?id=34463

Attachment 47909: Additional sanity checking
https://bugs.webkit.org/attachment.cgi?id=47909&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
I don't yet know what situation specifically triggered Simon's crash, because I
need more detail.

In the crash I stumbled upon, we were getting some seriously bogus values for
renderText->textLength(). However, under those same conditions,
renderText->caretMaxOffset() was 0. Checking that value before calling
convertUniCharToUTF8 with the bogus length solves my crasher.

Xan, thoughts?