[webkit-reviews] review denied: [Bug 34460] [Chromium] Add WebSecurityOrigin::createFromString factory : [Attachment 47894] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 34460: [Chromium] Add WebSecurityOrigin::createFromString factory
https://bugs.webkit.org/show_bug.cgi?id=34460

Attachment 47894: Patch
https://bugs.webkit.org/attachment.cgi?id=47894&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebSecurityOrigin.h

>      WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const
WebString& databaseIdentifier);
> +    WEBKIT_API static WebSecurityOrigin* createFromString(const WebString&
origin);

There's no reason for either of these to return pointers.

WebSecurityOrigin is already like a smart pointer class.  Just return by value.