[webkit-reviews] review granted: [Bug 34462] Fix a bug that Math.round() retunrs incorrect results for huge integers : [Attachment 47901] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 19:47:55 PST 2010


Darin Adler <darin at apple.com> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 34462: Fix a bug that Math.round() retunrs incorrect results for huge
integers
https://bugs.webkit.org/show_bug.cgi?id=34462

Attachment 47901: Patch
https://bugs.webkit.org/attachment.cgi?id=47901&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Patch seems fine. But you should consider my patch with ceil that avoids the
need for the separate if statement. You could use ? : instead of the way I did
it. Or use my code exactly as is (as long as it passes your tests).


More information about the webkit-reviews mailing list