[webkit-reviews] review granted: [Bug 34062] [Qt] Tuning and optimizations to GraphicsLayerQt : [Attachment 47858] tuning / optimiization to GraphicsLayerQt + added a comment about actual FPS improvement to the ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 16:07:13 PST 2010


Ariya Hidayat <ariya.hidayat at gmail.com> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 34062: [Qt] Tuning and optimizations to GraphicsLayerQt
https://bugs.webkit.org/show_bug.cgi?id=34062

Attachment 47858: tuning / optimiization to GraphicsLayerQt + added a comment
about actual FPS improvement to the ChangeLog
https://bugs.webkit.org/attachment.cgi?id=47858&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
> +	   [Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary

> +	   recaching, remove QTimer::singleShot and QPixmap::scaled, more
> +	   accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

You may want to wrap the last line properly.

Otherwise, LGTM.


More information about the webkit-reviews mailing list