[webkit-reviews] review granted: [Bug 34194] [BREWMP] Add conversions between IntPoint and AEEPoint : [Attachment 47486] Add conversions between IntPoint and AEEPoint
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 1 15:40:47 PST 2010
Eric Seidel <eric at webkit.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 34194: [BREWMP] Add conversions between IntPoint and AEEPoint
https://bugs.webkit.org/show_bug.cgi?id=34194
Attachment 47486: Add conversions between IntPoint and AEEPoint
https://bugs.webkit.org/attachment.cgi?id=47486&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
4 : m_x(static_cast<int>(point.x))
35 , m_y(static_cast<int>(point.y))
Why do you need static_cast? Shouldn't an int16 expand to an int32 without
cast?
Otherewise looks fine.
More information about the webkit-reviews
mailing list