[webkit-reviews] review granted: [Bug 33840] Provide a way to get page number with layoutTestController : [Attachment 47668] Patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 15:33:09 PST 2010


Eric Seidel <eric at webkit.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 33840: Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

Attachment 47668: Patch v4
https://bugs.webkit.org/attachment.cgi?id=47668&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why not FloatSize here?
 164 int PrintContext::pageNumberForElement(Element* element, float
pageWidthInPixels, float pageHeightInPixels)

I guess DRT doesn't know how to use FloatSize?


More information about the webkit-reviews mailing list