[webkit-reviews] review granted: [Bug 34364] REGRESSION(canvas editor): URLs are not syntax-higlighted as links in source view : [Attachment 47869] [PATCH] Proposed change.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 1 14:08:21 PST 2010
Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 34364: REGRESSION(canvas editor): URLs are not syntax-higlighted as links
in source view
https://bugs.webkit.org/show_bug.cgi?id=34364
Attachment 47869: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=47869&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + if (content.length > 1 && (quote === "\"" || quote === "'"))
> + content = content.substring(1, content.length - 1);
Shouldn't this be content.length >= 2 or content.length > 2?
More information about the webkit-reviews
mailing list