[webkit-reviews] review requested: [Bug 34260] check-webkit-style: is not reporting the carriage-return error for patches : [Attachment 47867] Proposed patch

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 34260: check-webkit-style: is not reporting the carriage-return error for
patches
https://bugs.webkit.org/show_bug.cgi?id=34260

Attachment 47867: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47867&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
I addressed the FIXME by adding the ability to limit the number of error
reports per category, per file.  (The essence of the existing carriage return
logic is that a carriage return error should be reported at most once per
file.)

It might be nice to enable this for the tab check, too.  See this, for
example--

https://bugs.webkit.org/show_bug.cgi?id=33475#c2

Note also that the submitted fix preserves the prevailing behavior that errors
for patch files should only be reported if they occur in a modified line.  This
wasn't being done with the existing "line 0" code (even if the existing code
were working).