[webkit-reviews] review granted: [Bug 32563] [V8] Generate toV8 conversion helpers, a la JSC bindings. : [Attachment 47864] Attempt #3.2

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 32563: [V8] Generate toV8 conversion helpers, a la JSC bindings.
https://bugs.webkit.org/show_bug.cgi?id=32563

Attachment 47864: Attempt #3.2
https://bugs.webkit.org/attachment.cgi?id=47864&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Yay! r=me, after fixing:

> +    switch (impl->pathSegType()) {
> +    case SVGPathSeg::PATHSEG_CLOSEPATH:		      return
toV8(static_cast<SVGPathSegClosePath*>(impl));

I know you copied this over, but this needs to be in WebKit style, with line
breaks/indents.

> Index: WebCore/Android.v8bindings.mk
> ===================================================================
> --- WebCore/Android.v8bindings.mk	(revision 54136)
> +++ WebCore/Android.v8bindings.mk	(working copy)
> @@ -87,8 +87,13 @@
>	\
>	bindings/v8/custom/V8AbstractWorkerCustom.cpp \
>	bindings/v8/custom/V8AttrCustom.cpp \
> +    bindings/v8/custom/V8BarInfoCustom.cpp \
> +    bindings/v8/custom/V8CSSRuleCustom.cpp \
>	bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp \
> +    bindings/v8/custom/V8CSSStyleSheetCustom.cpp \
> +    bindings/v8/custom/V8CSSValueCustom.cpp \
>	bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp \
> +    bindings/v8/custom/V8CanvasPixelArrayCustom.cpp \

Tabs in this file?