[webkit-reviews] review granted: [Bug 33951] [Android] Android lacks V8 equivalent of JavaInstanceJSC : [Attachment 47704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 11:19:30 PST 2010


Ariya Hidayat <ariya.hidayat at gmail.com> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 33951: [Android] Android lacks V8 equivalent of JavaInstanceJSC
https://bugs.webkit.org/show_bug.cgi?id=33951

Attachment 47704: Patch
https://bugs.webkit.org/attachment.cgi?id=47704&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
> +    // Try to find a good match for the overloaded method.  The
> +    // fundamental problem is that JavaScript doesn have the

Typo: doesn (actually also in JavaInstanceJSC.cpp).

Also, compared to others V8 JavaFoo version, this one very closely resembles
JavaInstanceJSC.cpp, so IMO the original copyright should be kept.

Otherwise, LGTM.


More information about the webkit-reviews mailing list