[webkit-reviews] review granted: [Bug 34335] ScriptCallFrame's do not get line numbers/source id's if the caller is unkown. : [Attachment 47829] Proposed patch and updated layout tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 10:00:53 PST 2010


Darin Adler <darin at apple.com> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 34335: ScriptCallFrame's do not get line numbers/source id's if the caller
is unkown.
https://bugs.webkit.org/show_bug.cgi?id=34335

Attachment 47829: Proposed patch and updated layout tests.
https://bugs.webkit.org/attachment.cgi?id=47829&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   *
platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed.

> +	   *
platform/mac/inspector/console-log-before-inspector-open-expected.txt: Removed.

> +	   *
platform/win/inspector/console-log-before-inspector-open-expected.txt: Removed.


Change log doesn't say why you did this. I presume that these platform-specific
results were actually just working around the bug?


More information about the webkit-reviews mailing list