[webkit-reviews] review granted: [Bug 34359] REGRESSION(canvas editor): Syntax highlighting in source view of Resources pane stops half-way : [Attachment 47845] [PATCH] Proposed fix.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 34359: REGRESSION(canvas editor): Syntax highlighting in source view of
Resources pane stops half-way
https://bugs.webkit.org/show_bug.cgi?id=34359

Attachment 47845: [PATCH] Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=47845&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
>  2010-02-01  Pavel Feldman  <pfeldman at chromium.org>
>  
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Web Inspector: Syntax highlighting in source view of Resources pane
stops half-way.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=34359
> +
> +	   * inspector/front-end/NativeTextViewer.js:
> +	   (WebInspector.NativeTextViewer.prototype._createLineDivs):
> +	   (WebInspector.NativeTextViewer.prototype._lineHeight):
> +	   (WebInspector.NativeTextViewer.prototype.initFontMetrics):
> +	   * inspector/front-end/SourceFrame.js:
> +	   (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
> +	   * inspector/front-end/SourceHTMLTokenizer.js:
> +	   (WebInspector.SourceHTMLTokenizer):
> +	   (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
> +	   * inspector/front-end/SourceHTMLTokenizer.re2js:
> +	   * inspector/front-end/TextEditor.js:
> +	   (WebInspector.TextEditor.prototype.initFontMetrics):
> +	   (WebInspector.TextEditor.prototype._registerShortcuts):
> +	   * inspector/front-end/inspectorSyntaxHighlight.css:

You should describe what the problem was and how it was fixed in the ChangeLog.


Especially for these cryptic lexer changes.