[webkit-reviews] review granted: [Bug 30004] [GStreamer] Should handle BUFFERING messages : [Attachment 46056] draw the buffering status in the media controls

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 30004: [GStreamer] Should handle BUFFERING messages
https://bugs.webkit.org/show_bug.cgi?id=30004

Attachment 46056: draw the buffering status in the media controls
https://bugs.webkit.org/attachment.cgi?id=46056&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 680	 // Don't bother drawing an empty area.
 681	 if (!bufferedRect.isEmpty()) {

This should be an early return for the true case instead.

7  Time: 2.2
 7 Time: 2.1

Why has this changed?

Patch looks good, overall, so just change the if to an early return, please,
and add a comment regarding the change in drag-timebar.