[webkit-reviews] review granted: [Bug 34405] MediaControlTimeDisplayElement should defer time formatting to the theme : [Attachment 47811] Initial Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 1 08:00:21 PST 2010
Eric Carlson <eric.carlson at apple.com> has granted Nick Young
<nicholas.young at nokia.com>'s request for review:
Bug 34405: MediaControlTimeDisplayElement should defer time formatting to the
theme
https://bugs.webkit.org/show_bug.cgi?id=34405
Attachment 47811: Initial Patch
https://bugs.webkit.org/attachment.cgi?id=47811&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> + virtual String formatMediaControlsTime(float time);
> + virtual String formatMediaControlsCurrentTime(float currentTime, float
duration);
> + virtual String formatMediaControlsRemainingTime(float currentTime, float
duration);
These should all be const.
r=me with this change, thanks!
More information about the webkit-reviews
mailing list