[webkit-reviews] review denied: [Bug 34170] [Qt] Javascript undefined > 0 returns true on Symbian : [Attachment 47838] proposed fix for jsvalue.cpp

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Janne Koskinen <koshuin at gmail.com>'s
request for review:
Bug 34170: [Qt] Javascript undefined > 0 returns true on Symbian
https://bugs.webkit.org/show_bug.cgi?id=34170

Attachment 47838: proposed fix for jsvalue.cpp
https://bugs.webkit.org/attachment.cgi?id=47838&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#if PLATFORM(QT)
> +#include <qnumeric.h>
> +#endif

Includes with ifdefs go into a separate paragraph. Not sorted into the normal
includes.

The ifdef should definitely be for Symbian rather than for Qt. This patch is
all about working around a Symbian bug. And I am also really surprised it's
broken!

> +    return qQNaN();

This seems OK, but ideally we'd work around the Symbian bug without requiring
Qt here. Is there any other way to do it? For example, does 0.0 / 0.0 work? Or
is there an NAN macro on Symbian?

review- but something like this would be fine -- just please consider my
comments.