[webkit-reviews] review requested: [Bug 34416] [Qt] Build without SSL support is broken : [Attachment 47839] build fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 1 07:02:18 PST 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has asked for review:
Bug 34416: [Qt] Build without SSL support is broken
https://bugs.webkit.org/show_bug.cgi?id=34416
Attachment 47839: build fix
https://bugs.webkit.org/attachment.cgi?id=47839&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
You need to put the patch up for review, I have done so now.
> + } else
> m_socket = new QTcpSocket(this);
> +
> + if (!m_socket)
> + return;
Why did you add this early return. The new is supposed to return something
valid, unless we are out of memory.
More information about the webkit-reviews
mailing list