[webkit-reviews] review granted: [Bug 51784] Some renaming and refactoring of form element code : [Attachment 77733] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 31 14:26:09 PST 2010


mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 51784: Some renaming and refactoring of form element code
https://bugs.webkit.org/show_bug.cgi?id=51784

Attachment 77733: Patch
https://bugs.webkit.org/attachment.cgi?id=77733&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=77733&action=review

> WebCore/html/HTMLFormElement.cpp:629
> +    HTMLFormControlElement* aliasElement = elementForAlias(name);
> +    if (aliasElement) {

I’d move the definition of aliasElement into the if statement, since it doesn’t
seem to be used outside of it.


More information about the webkit-reviews mailing list