[webkit-reviews] review denied: [Bug 32865] [Qt] QWebElement::attribute always returns empty result for input's values : [Attachment 72454] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 31 08:09:39 PST 2010


Ariya Hidayat <ariya.hidayat at gmail.com> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 32865: [Qt] QWebElement::attribute always returns empty result for input's
values
https://bugs.webkit.org/show_bug.cgi?id=32865

Attachment 72454: Patch
https://bugs.webkit.org/attachment.cgi?id=72454&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72454&action=review

r- for minor issue, otherwise LGTM.
In all cases, needs to be coordinated with Oslo as this involves API addition.

> WebKit/qt/Api/qwebelement.cpp:400
> +QString QWebElement::currentValue() const

New API function: require \since tag.


More information about the webkit-reviews mailing list