[webkit-reviews] review granted: [Bug 51753] Web Inspector: move delayed search implementation to SourceFrame : [Attachment 77682] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 31 04:20:23 PST 2010


Pavel Feldman <pfeldman at chromium.org> has granted  review:
Bug 51753: Web Inspector: move delayed search implementation to SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=51753

Attachment 77682: Patch.
https://bugs.webkit.org/attachment.cgi?id=77682&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77682&action=review

> WebCore/inspector/front-end/SourceView.js:135
> +	   function didFindSearchMatches(searchResults)

It seems strange that you only need this callback to manage searchResults in
SourceView. Consider moving to SourceFrame instead.


More information about the webkit-reviews mailing list