[webkit-reviews] review granted: [Bug 51612] Add XML parser benchmark : [Attachment 77463] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 31 01:37:52 PST 2010
Adam Barth <abarth at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 51612: Add XML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51612
Attachment 77463: Patch
https://bugs.webkit.org/attachment.cgi?id=77463&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77463&action=review
Thanks. I'll land this manually before moving these files to the new
PerformanceTests folder.
> WebCore/benchmarks/parser/resources/runner.js:95
> +function start(rC, rF) {
> + runCount = rC;
> + runFunction = rF;
> +
> + log("Running " + runCount + " times");
> + run();
> +}
rC and rF are pretty short variable names. Generally, we prefer to use real
english words rather than abbreviations. I'll tweak this during landing.
More information about the webkit-reviews
mailing list