[webkit-reviews] review denied: [Bug 30357] [Qt] Be able to specify a header and footer when printing from WebKit : [Attachment 77691] Patch

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has denied Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 30357: [Qt] Be able to specify a header and footer when printing from
WebKit
https://bugs.webkit.org/show_bug.cgi?id=30357

Attachment 77691: Patch
https://bugs.webkit.org/attachment.cgi?id=77691&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77691&action=review

r-, in particular because the merging with 26584 needs to be planned

> WebKit/qt/Api/qwebframe.cpp:1431
> +QWebPrinter* QWebFrame::webPrinter()
> +{
> +    static QWebPrinter* p = 0;
> +    if (!p)
> +	  p = new QWebPrinter;
> +
> +    return p;
> +}

This will leak memory.

> WebKit/qt/Api/qwebframe.h:131
> +class QWEBKIT_EXPORT QWebPrinter {
> +public:
> +    bool printHeaderAndFooter() const { return hasHeaderAndFooter; }
> +    void setPrintHeaderAndFooter(bool flag = true) { hasHeaderAndFooter =
flag; }
> +
> +    void setHeader(const QString& left, const QString& center, const
QString& right);
> +    void setFooter(const QString& left, const QString& center, const
QString& right);
> +
> +private:
> +    QWebPrinter()
> +	   : hasHeaderAndFooter(false)
> +    {}
> +
> +    QString headerLeft;
> +    QString headerCenter;
> +    QString headerRight;
> +    QString footerLeft;
> +    QString footerCenter;
> +    QString footerRight;
> +
> +    bool hasHeaderAndFooter;
> +
> +    friend class QWebFrame;
> +};
> +#endif

This is a whole new set of API. Needs some coordinated discussion.

For example, this should be merged to Bug 26584.