[webkit-reviews] review canceled: [Bug 51683] [v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map : [Attachment 77602] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has canceled anton muhin <antonm at chromium.org>'s
request for review:
Bug 51683: [v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only
a value type stored in the DOM map
https://bugs.webkit.org/show_bug.cgi?id=51683

Attachment 77602: Patch
https://bugs.webkit.org/attachment.cgi?id=77602&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77602&action=review

> WebCore/bindings/v8/V8DOMMap.h:-63
> -	   virtual bool removeIfPresent(KeyType* key, v8::Persistent<v8::Data>
value) = 0;

Why is this virtual if Its never overridden?