[webkit-reviews] review denied: [Bug 51588] Web Inspector: implement script beautifier prototype : [Attachment 77408] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 30 06:14:00 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 51588: Web Inspector: implement script beautifier prototype
https://bugs.webkit.org/show_bug.cgi?id=51588

Attachment 77408: Patch.
https://bugs.webkit.org/attachment.cgi?id=77408&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77408&action=review

Looks good with comment. Please fix it first.

> WebCore/inspector/front-end/SourceFrame.js:793
> +    formatSource: function()

It is worth extracting SourceFrameFromatter class that would be used by the
SourceFrame for better code clarity.


More information about the webkit-reviews mailing list