[webkit-reviews] review granted: [Bug 51745] Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox. : [Attachment 77675] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 51745: Web Inspector: breakpoint is not disabled when clicking on
breakpoints sidebar pane checkbox.
https://bugs.webkit.org/show_bug.cgi?id=51745

Attachment 77675: Patch.
https://bugs.webkit.org/attachment.cgi?id=77675&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77675&action=review

> WebCore/inspector/front-end/Breakpoint.js:55
> +	   this.remove();

It would be great if breakpoint had two states: "resolved" and "unresolved". In
that case, setting enabled to false would simply make it unresolved unless
backend confirms disabling.