[webkit-reviews] review denied: [Bug 41414] Web Inspector: autocompletion for CSS property values in Styles pane : [Attachment 77622] [PATCH] Alternative solution with rebaselined test

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 41414: Web Inspector: autocompletion for CSS property values in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=41414

Attachment 77622: [PATCH] Alternative solution with rebaselined test
https://bugs.webkit.org/attachment.cgi?id=77622&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77622&action=review

> WebCore/inspector/front-end/CSSKeywordCompletions.js:1107
> +    "-webkit-text-emphasis-style": [

I'd suggest that we:
- remove \n between values
- group -webkit items

> WebCore/inspector/front-end/StylesSidebarPane.js:1635
> +	   var character = event.data.toLowerCase();

You should use TextPrompt instead. It has configurable completions and
stopCharacters. You will need to make it a bit more flexible.