[webkit-reviews] review granted: [Bug 51001] Moving or selecting backwards by words jumps to start of contenteditable region if contenteditable=false span is encountered : [Attachment 77655] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 29 17:54:25 PST 2010


Darin Adler <darin at apple.com> has granted Benjamin (Ben) Kalman
<kalman at chromium.org>'s request for review:
Bug 51001: Moving or selecting backwards by words jumps to start of
contenteditable region if contenteditable=false span is encountered
https://bugs.webkit.org/show_bug.cgi?id=51001

Attachment 77655: Patch
https://bugs.webkit.org/attachment.cgi?id=77655&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77655&action=review

> WebCore/editing/TextIterator.cpp:1143
> +		   if (!m_node->parentOrHostNode())
>		       break;
> +		   m_node = m_node->parentOrHostNode();

I would have used a local variable here, but it’s probably fine not to.


More information about the webkit-reviews mailing list