[webkit-reviews] review denied: [Bug 22759] dropdown menu disappears on mouse-over : [Attachment 76255] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied dgrogan at google.com's request for
review:
Bug 22759: dropdown menu disappears on mouse-over
https://bugs.webkit.org/show_bug.cgi?id=22759

Attachment 76255: patch
https://bugs.webkit.org/attachment.cgi?id=76255&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76255&action=review

Change looks fine, but review- for a slight bit of unneeded work due to the way
the code is structured.

> WebCore/css/CSSPrimitiveValue.cpp:439
> +    double roundedResult = result;
> +    if (shouldRound)
> +	   roundedResult = round(result);
>      if (!applyZoomMultiplier || multiplier == 1.0)
> -	   return result;
> -	
> +	   return roundedResult;

Why compute roundedResult outside the if statement where it’s being returned?
That seems like extra work for no benefit. I would write:

    if (!applyZoomMultiplier || multiplier == 1.0)
	return shouldRound ? round(result) : result;

Or the equivalent with two if statements.