[webkit-reviews] review granted: [Bug 51134] Move loading related code from MemoryCache to CachedResourceLoader : [Attachment 76761] fix style

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 51134: Move loading related code from MemoryCache to CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=51134

Attachment 76761: fix style
https://bugs.webkit.org/attachment.cgi?id=76761&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76761&action=review

> WebCore/css/CSSImageValue.cpp:75
> +	   CachedImage* cachedImage = loader->requestImage(url);
>	   if (cachedImage) {

Could put the definition inside the if statement.

> WebCore/loader/cache/CachedResource.h:54
> +    friend class CachedResourceLoader;

Is this really necessary? Can we do something to avoid it?

> WebCore/loader/cache/CachedResourceLoader.cpp:74
> +    default:
> +	   break;

Normally we try to avoid having a default. That way, the compiler will warn us
if we forget to include a case. Just leaving out "default: break" should do the
trick.