[webkit-reviews] review granted: [Bug 51327] [GTK] minimal build fails at link time due to missing sqlite3 symbols : [Attachment 77611] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 51327: [GTK] minimal build fails at link time due to missing sqlite3
symbols
https://bugs.webkit.org/show_bug.cgi?id=51327

Attachment 77611: proposed patch
https://bugs.webkit.org/attachment.cgi?id=77611&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77611&action=review

Thanks! Please fix some of these really minor issues before landing this.

> configure.ac:844
> +# check if sqlite 3 is available. Error out only if one of the

Please fix the capitalization here before landing. :)

> configure.ac:863
> +   AC_MSG_ERROR([SQLite3 is required to enable Database support])

For instance, if the error was due to missing SQLite and the feature was
offline web applications, this message would be incorrect. Do you mind making
it more general (or more specific with if-else blocks) before landing?