[webkit-reviews] review denied: [Bug 29071] [HTML5][Forms] Support for :in-range and :out-of-range CSS selectors : [Attachment 77592] Patch.

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 29071: [HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=29071

Attachment 77592: Patch.
https://bugs.webkit.org/attachment.cgi?id=77592&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77592&action=review

Thank you for working on this!

> WebCore/css/CSSStyleSelector.cpp:2678
> +	       case CSSSelector::PseudoInRange:
> +		   return e && e->isInRange();
> +	       case CSSSelector::PseudoOutOfRange:
> +		   return e && e->isOutOfRange();

Please add document()->setContainsValidaityStyleRules() like PseudoValid and
PseudoInvalid, and update CSSStyleSelector::canShareStyleWithElement().

> WebCore/html/InputType.h:93
>      virtual bool supportsRequired() const;
> +    virtual bool supportsRangeLimitation() const;
>      virtual bool valueMissing(const String&) const;

nit: supportsRangeLimitation() should be put just before rangeUnderflow().

> WebCore/html/NumberInputType.h:65
> +    virtual bool supportsRangeLimitation() const { return true; }

nit: We have no reason to have the body of a virtual function in a header file.


> WebCore/html/RangeInputType.h:62
> +    virtual bool supportsRangeLimitation() const { return true; }

ditto.

> LayoutTests/ChangeLog:16
> +	   * fast/forms/controls-in-range-expected.txt: Added.
> +	   * fast/forms/controls-in-range.html: Added.
> +	   * fast/forms/controls-invalid-value-in-range-expected.txt: Added.
> +	   * fast/forms/controls-invalid-value-in-range.html: Added.
> +	   * fast/forms/controls-out-of-range-expected.txt: Added.
> +	   * fast/forms/controls-out-of-range.html: Added.
> +	   * fast/forms/script-tests/controls-in-range.js: Added.
> +	   * fast/forms/script-tests/controls-invalid-value-in-range.js: Added.

> +	   * fast/forms/script-tests/controls-out-of-range.js: Added.

These tests should be named as fast/css/pseudo-*.html