[webkit-reviews] review requested: [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6 : [Attachment 77597] patch incorporated Martin's modifications and Mark's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 28 18:43:35 PST 2010


Koan-Sin Tan <koansin.tan at gmail.com> has asked	for review:
Bug 50867: [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867

Attachment 77597: patch incorporated Martin's modifications and Mark's comments
https://bugs.webkit.org/attachment.cgi?id=77597&action=review

------- Additional Comments from Koan-Sin Tan <koansin.tan at gmail.com>
using OS(DARWIN) and PLATFORM(CF)  to determine which UUID generation function
we should use UUID.cpp


Note that  #elif (OS(LINUX) && PLATFORM(CHROMIUM)) || (OS(DARWIN) &&
!PLATFORM(CF)) will run into a bug of check-webkit-style and && has higher
precedence than ||, so I just removed parentheses


More information about the webkit-reviews mailing list