[webkit-reviews] review denied: [Bug 45423] [Gtk] Port tiled backing store : [Attachment 77469] updated patch to work with the trunk

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Joone Hur <joone at kldp.org>'s
request for review:
Bug 45423: [Gtk] Port tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=45423

Attachment 77469: updated patch to work with the trunk
https://bugs.webkit.org/attachment.cgi?id=77469&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77469&action=review

Looks good. There are a few issues that I can see though.

> WebCore/page/Frame.cpp:865
> -    unsigned size = paintedArea.size();
> +    int size = paintedArea.size();

Is this change related?

> WebCore/platform/graphics/gtk/TileGtk.cpp:7
> +   Redistribution and use in source and binary forms, with or without
> +   modification, are permitted provided that the following conditions
> +   are met:

Nit: do you mind adding the asterisks here so that this license block looks
like others in this directory?

> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:437
> +    notImplemented();

Is this really notImplemented() or is it an empty implementation? There's a
subtle difference.

> WebKit/gtk/webkit/webkitwebsettings.cpp:920
> +    /**
> +	* WebKitWebSettings: enable-tiled-backing-store:
> +	*
> +	* Enable or disable tiled backing store

This documentation should be expanded greatly. What is the tiled backing store
and why, as an embedder, would I want to turn it on?

> WebKit/gtk/webkit/webkitwebview.cpp:721
> +	   if (frame->tiledBackingStore())
> +		   renderFromTiledBackingStore(frame, &context, clipRect);
> +	   else
> +#endif
>	       frame->view()->paint(&context, rect);

The indentation seems incorrect here.