[webkit-reviews] review canceled: [Bug 46061] svn-apply updates date of wrong change log entry for a change log diff that contains two consecutive entries with the same author and date : [Attachment 77480] Patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 28 16:28:11 PST 2010


Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 46061: svn-apply updates date of wrong change log entry for a change log
diff that contains two consecutive entries with the same author and date
https://bugs.webkit.org/show_bug.cgi?id=46061

Attachment 77480: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=77480&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Removed extraneous comment in added unit test file
fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl.

Strengthened for-loop for updating the date state index by noticing that if
there exists a line L_i that matches the regular expression $dateStartRegEx
after shifting the overlapping lines towards the front then i \in
[$chunkStartIndex, $dateStartIndex - 1].


More information about the webkit-reviews mailing list