[webkit-reviews] review granted: [Bug 51667] JSON.stringify must exist as a function taking 3 parameters : [Attachment 77537] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Helder Correia <helder at sencha.com>'s
request for review:
Bug 51667: JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667

Attachment 77537: Patch
https://bugs.webkit.org/attachment.cgi?id=77537&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It appears it does actually take 3 values:

// ECMA-262 v5 15.12.3
EncodedJSValue JSC_HOST_CALL JSONProtoFuncStringify(ExecState* exec)
{
    if (!exec->argumentCount())
	return throwVMError(exec, createError(exec, "No input to stringify"));
    JSValue value = exec->argument(0);
    JSValue replacer = exec->argument(1);
    JSValue space = exec->argument(2);
    return JSValue::encode(Stringifier(exec, replacer,
space).stringify(value));
}

We need to find a way to catch this class of bugs somehow.