[webkit-reviews] review denied: [Bug 51671] <VT> and <FF> are not valid JSON whitespace characters : [Attachment 77543] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Helder Correia <helder at sencha.com>'s
request for review:
Bug 51671: <VT> and <FF> are not valid JSON whitespace characters
https://bugs.webkit.org/show_bug.cgi?id=51671

Attachment 77543: Patch
https://bugs.webkit.org/attachment.cgi?id=77543&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77543&action=review

The fix looks fine.  But making isAllowedSpace clearer will help make this code
easier to understand for future peopel hacking here.

> JavaScriptCore/runtime/LiteralParser.cpp:38
> +static inline bool isAllowedSpace(const UChar c)

Seems this name should more clearly state what type of allowed space this is. 
is this a JSON Whitespace?  is this a SomeSpecificSpecNameWhitespace?  It would
be best to provide a link next to this function where the list of whitespace
chars are defined.  How do I validate that this is the right list when I'm
looking at this code a month from now?