[webkit-reviews] review granted: [Bug 51687] [Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform() : [Attachment 77575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 28 13:43:57 PST 2010


Eric Seidel <eric at webkit.org> has granted Jan Erik Hanssen
<jhanssen at gmail.com>'s request for review:
Bug 51687: [Qt] GraphicsContext::getCTM() does not need to make a copy of
QPainter::combinedTransform()
https://bugs.webkit.org/show_bug.cgi?id=51687

Attachment 77575: Patch
https://bugs.webkit.org/attachment.cgi?id=77575&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77575&action=review

> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:292
>      return AffineTransform(matrix.m11(), matrix.m12(), matrix.m21(),

Why don't we just have a AffineTransform(const QTransform&) constructor which
is compiled on Qt?


More information about the webkit-reviews mailing list